Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DEXP-554913 #1916

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Fix DEXP-554913 #1916

merged 2 commits into from
Nov 9, 2020

Conversation

krasnotsvetov
Copy link
Collaborator

No description provided.

@citizenmatt
Copy link
Member

I thought the protocol guid was for the version of the protocol itself, so we should only update it if the serialisation format/wire protocol changes, rather than the model changing. The model has its own serialisation hash that we listen to for out of date models, doesn't it?

@van800
Copy link
Contributor

van800 commented Nov 3, 2020

For now we have only manual mechanism - when guids are different - avoid connection attempt.

@krasnotsvetov krasnotsvetov merged commit 1e57e99 into net203 Nov 9, 2020
@citizenmatt citizenmatt deleted the net203-dexp-554913 branch December 16, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants