Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunch of smaller fixes #1923

Merged
merged 20 commits into from
Nov 20, 2020
Merged

Bunch of smaller fixes #1923

merged 20 commits into from
Nov 20, 2020

Conversation

citizenmatt
Copy link
Member

@citizenmatt citizenmatt commented Nov 18, 2020

This attribute can be used on MonoBehaviour and ScriptableObject. See #145
The [Inject] API was removed from the Entities package around 0.25. See https://forum.unity.com/threads/api-deprecation-faq-0-0-23.636994/
Recognises fields marked with [SerializeReference] as serialised fields. Also supports the type of the field being an abstract type

Fixes #1340
Doesn't add tests for providers based on folder structure

Fixes #626
@citizenmatt citizenmatt added this to the Rider 2020.3 milestone Nov 18, 2020
@citizenmatt citizenmatt self-assigned this Nov 18, 2020
@@ -163,7 +166,7 @@ class UnityLogPanelView(lifetime: Lifetime, project: Project, private val logMod
@Suppress("SpellCheckingInspection")
private val listPanel = JPanel(MigLayout("ins 0, gap 0, flowy, novisualpadding, fill", "", "[][min!]")).apply {
add(JBScrollPane(eventList).apply { horizontalScrollBarPolicy = ScrollPaneConstants.HORIZONTAL_SCROLLBAR_NEVER }, "grow, wmin 0")
add(searchTextField, "growx")
add(searchTextField, "grow")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @van800

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an expert in that UI tweaks, but I tried the branch and this change doesn't brake the layout of UnityLogView.

@citizenmatt what this change does?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means the search field will grow both in x and y. So it was stretching to fit horizontally, but didn't grow vertically, so if there was a larger font, the height would be wrong.

yield break;
var version = project != null
? context.Solution.GetComponent<UnityVersion>().GetActualVersion(project)
: context.Solution.GetComponent<UnityVersion>().ActualVersionForSolution.Value;
Copy link
Contributor

@van800 van800 Nov 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather check ActualVersionForSolution first. It might be faster.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine for now. We're using GetActualVersion(IProject) in lots of places, including UnityApi for completion, usage suppression and so on. I'm up for reviewing UnityVersion usage in 211 though - it might be worth removing the IProject API completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure "Use source for symbol files" is true for Unity projects
3 participants