Improve notifications #1958
Merged
Improve notifications #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iliya-usov
reviewed
Jan 7, 2021
...tlin/com/jetbrains/rider/plugins/unity/notifications/OpenUnityProjectAsFolderNotification.kt
Outdated
Show resolved
Hide resolved
|
I had to merge fresh net211 and found out that now it works as expected. |
|
Notification for the described case (EditorInstance.json is present and protocol connection was not initialized within 1 second): OutOfSyncNotification: |
citizenmatt
requested changes
Jan 14, 2021
resharper/resharper-unity/src/Rider/Protocol/BackendUnityProtocol.cs
Outdated
Show resolved
Hide resolved
...tlin/com/jetbrains/rider/plugins/unity/notifications/OpenUnityProjectAsFolderNotification.kt
Outdated
Show resolved
Hide resolved
...tlin/com/jetbrains/rider/plugins/unity/notifications/OpenUnityProjectAsFolderNotification.kt
Outdated
Show resolved
Hide resolved
...tlin/com/jetbrains/rider/plugins/unity/notifications/OpenUnityProjectAsFolderNotification.kt
Outdated
Show resolved
Hide resolved
...tlin/com/jetbrains/rider/plugins/unity/notifications/OpenUnityProjectAsFolderNotification.kt
Show resolved
Hide resolved
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes people get into non-working Rider integration, when they occasionally have External Script Editor turned into "Open by file extension".
For this case, we check that
Library/EditorInstance.jsonis present and protocol connection was not initialized within 1 second, so we show notification.https://youtrack.jetbrains.com/issue/RIDER-56325