Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-click on assembly in Unity Explorer should open it in AssemblyExplorer #1996

Merged
merged 4 commits into from
Jan 12, 2021
Merged

Double-click on assembly in Unity Explorer should open it in AssemblyExplorer #1996

merged 4 commits into from
Jan 12, 2021

Conversation

van800
Copy link
Contributor

@van800 van800 commented Jan 11, 2021

RIDER-54873

@van800 van800 merged commit ca7d961 into net211 Jan 12, 2021
@van800 van800 deleted the net211-RIDER-54873-double-click branch January 12, 2021 13:28
citizenmatt
citizenmatt reviewed Jan 12, 2021
View reviewed changes
rider/src/main/kotlin/com/jetbrains/rider/internal/dump/DumpUnityExplorerAction.kt
@@ -0,0 +1,35 @@
package com.jetbrains.rider.internal.dump
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't noticed where this file was placed. Can we move it to com.jetbrains.rider.plugins.unity.actions.internal please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizenmatt citizenmatt citizenmatt left review comments

@xtmq xtmq xtmq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@van800 @citizenmatt @xtmq