Ensure Packages folder is indexed #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also means that the "non-project file" dialog is no longer shown for files in the Packages folder (files in the content model are not considered non-project).
van800
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
Packagesfolder contains any project code, it wasn't being explicitly indexed, soPackages/manifest.jsonwasn't added to the content model, and would show the "non-project file" dialog when trying to modify. If thePackagesfolder doesn't contain any project, it was being explicitly added, so the dialog wasn't shown. I don't know whyPackageswasn't being indexed, because with the same code,Assetswas indexed.Note that this code will be rewritten soon, when the new project model is merged. It's still worth fixing now, to make sure that the rewritten version also correctly indexes both
AssetsandPackages.