-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnlineHelp or Local Documentation by F1 + fixes in quick doc link to external doc #2050
Conversation
resharper/resharper-unity/src/Application/UI/Help/ShowUnityHelp.cs
Outdated
Show resolved
Hide resolved
resharper/resharper-unity/src/Application/UI/Help/ShowUnityHelp.cs
Outdated
Show resolved
Hide resolved
...rper/resharper-unity/src/CSharp/Feature/OnlineHelp/UnityCompiledElementOnlineHelpProvider.cs
Outdated
Show resolved
Hide resolved
...rper/resharper-unity/src/CSharp/Feature/OnlineHelp/UnityCompiledElementOnlineHelpProvider.cs
Outdated
Show resolved
Hide resolved
resharper/resharper-unity/src/CSharp/Feature/OnlineHelp/UnityOnlineHelpProvider.cs
Outdated
Show resolved
Hide resolved
.../resharper-unity/src/CSharp/Feature/Services/QuickDoc/UnityEventFunctionQuickDocPresenter.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
var englishRoot = root.Combine("en"); | ||
if (!englishRoot.ExistsDirectory) | ||
return root.GetChildDirectories().FirstOrDefault(englishRoot); | ||
return englishRoot; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wow. Does this mean they're installing non-English documentation now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really. It can be downloaded separately and manually put to the folder
https://docs.unity3d.com/Manual/OfflineDocumentation.html
docs.unity3d.com
.RIDER-33108 Allow to open Unity local documentation.
Need to test Re# version.
Show links to dotnet/mono/unity documentation
RIDER-55736 Tweak external documentation link for generic methods
RIDER-39068 Improve QuickDoc API to include external documentation URL
RIDER-57745 Wrong page opens in external documentation
RIDER-60297 External Doc link for parameter of event function should go to eventfunction doc instead
RIDER-55737 Allow customizing QuickDoc link to use localized Unity documentation