-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exceptions in debugger extension #2057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RIDER-60794, Fixes RIDER-60795
Fixes RIDER-60798
Fixes DEXP-570265
Fixes DEXP-561412
Fixes DEXP-577753
* MissingComponentException - thrown by "null" instance objects returned from GetComponent for a Component that isn't attached to the current GameObject. Fixes DEXP-585430 * MissingReferenceException - thrown by destroyed objects. Fixes DEXP-534612 * UnassignedReferenceException - thrown by "null" instance objects in a serialised field that has never been assigned. Fixes DEXP-558487
krasnotsvetov
approved these changes
Apr 12, 2021
krasnotsvetov
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles a number of exceptions generated while evaluating extra data such as "Active Scene", "this.gameObject", "Scene Path" and so on.
EvaluatorAbortedException
rather than log as error. This is a process control exception and shouldn't be logged. Fixes DEXP-570625UnityException
thrown when evaluating API calls at invalid moments, e.g. callingGetActiveScene
in aMonoBehaviour
constructor. This could break evaluation of an entire UnityObject
. Exception is caught and silently logged at verbose. Fixes RIDER-60794 and RIDER-60795MissingComponentException
and silently logs. Thrown by "null" instances returned fromGetComponent
when there isn't aComponent
attached to the currentGameObject
. Fixes DEXP-585430MissingReferenceException
and silently logs. Thrown by calling APIs from destroyed objects. Fixes DEXP-534612UnassignedReferenceException
and silently logs. Thrown by "null" instance objects created for an unassigned serialised field. Fixes DEXP-558487