Fix exception when saving AsmDef file template #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes RIDER-61376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsmDef file template uses the
MustBeInProjectWithUnityVersionscope point that is parameterised with a Unity version. The default value is2017.3, because that's the first version that supported.asmdeffiles. Unfortunately, saving the template tries to save the scope point with the version serialised in 3 parts (major.minor.build) and if there are only 2 parts (2017.3) then it will throw an exception and the macros aren't saved.This is a problem if the file template is modified to add a macro - the text content is saved, but the macro isn't. When evaluating, the macro placeholder is left in place. See RIDER-61376