Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues resolving packages #2084

Merged
merged 4 commits into from
May 7, 2021
Merged

Conversation

citizenmatt
Copy link
Member

@citizenmatt citizenmatt commented May 6, 2021

This PR will fix a couple of edge cases while resolving packages and the packages-lock.json file is disabled:

  • Fix an issue displaying a package dependency that has been resolved when the package dependency resolution strategy is set to highestPatch, highestMinor or highest. In this case, Unity can resolve a dependency to a higher version than requested in a requiring package's package.json. Rider doesn't have this information, so resolves the dependency against the contents of Library/PackageCache.
  • Fix an issue displaying a Git based package when the lock file is disabled. There is no hash to use to look up the package in the local package cache. Instead, we look for the package ID as a prefix in the local package cache.
  • Add extra checks for packages that take precedence over resolved dependencies. Previously, the code only considered embedded packages as taking precedence. As per the docs, any embedded, local, git or built in packages take precedence over a requested version in a dependency.

@citizenmatt citizenmatt added this to the Rider 2021.2 milestone May 6, 2021
@citizenmatt citizenmatt self-assigned this May 6, 2021
Copy link
Contributor

@van800 van800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@citizenmatt citizenmatt merged commit 32c7f4d into net211 May 7, 2021
@citizenmatt citizenmatt deleted the net211-mte-resolving-packages branch May 7, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants