Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support debugging local UWP players + other debugger extension updates #2098

Merged
merged 8 commits into from
May 25, 2021

Conversation

citizenmatt
Copy link
Member

@citizenmatt citizenmatt commented May 24, 2021

This PR:

  • Adds support for debugging local UWP players. UWP processes are not allowed to accept incoming socket connections from the local machine in order to isolate Windows Store apps. Remote players are not affected. This change will launch the CheckNetIsolation tool to temporarily enable loopback connections. Fixes RIDER-62707
  • Ignores the "break on unhandled exceptions" setting for IL2CPP players. This matches the behaviour for the Mono 4.x runtime, which ignores this setting. I'm not clear why yet. This behaviour is controlled by an option, so we can return to the original behaviour if required. This fixes RIDER-62321. Ignoring this setting also works around some other issues with IL2CPP. E.g. an exception thrown from a call stack with no source at all (RIDER-62320).
  • Refactors debugger worker extension options to use the protocol rather than environment variables. Options are now updated live in the debugger worker process, but won't necessarily redraw until state changes (e.g. changing the "extend value rendering" option doesn't force redrawing the list of variables)
  • Refactors iOS USB debugging proxy creation to use proper start info handler mechanism over the protocol, rather than cheating with environment variables

@citizenmatt citizenmatt added this to the Rider 2021.2 milestone May 24, 2021
@citizenmatt citizenmatt requested a review from van800 May 24, 2021 21:02
@citizenmatt citizenmatt self-assigned this May 24, 2021
Copy link
Contributor

@van800 van800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@citizenmatt citizenmatt merged commit 3f76f3e into net212 May 25, 2021
@citizenmatt citizenmatt deleted the net212-mte-debugger-model branch May 25, 2021 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants