Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Show in Unity" for local packages #2124

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Conversation

van800
Copy link
Contributor

@van800 van800 commented Jul 19, 2021

This action "Show in Unity" can be called directly on current active file via Shift-Shift or for some files we show a notification in the editor with link to "Show in Unity" action.

This PR fixes the action for local packages and also avoids showing a link in notification for "meta" files.
https://youtrack.jetbrains.com/issue/RIDER-65128

@van800 van800 requested a review from citizenmatt July 19, 2021 13:15
@van800 van800 self-assigned this Jul 19, 2021
@van800 van800 changed the title Fix "Show in Unity" for local packages (#2123) Fix "Show in Unity" for local packages Jul 19, 2021
@van800 van800 merged commit 7bd87ca into net212 Jul 19, 2021
@van800 van800 deleted the net212-fix_Show_In_Unity-2 branch July 19, 2021 15:06
van800 added a commit that referenced this pull request Jul 19, 2021
* Fix "Show in Unity" for local packages (#2123)

* changelog

* speedup
@van800
Copy link
Contributor Author

van800 commented Aug 2, 2021

We have found a behaviour of Path.GetFullPath, which brakes logic in this PR
image
Only the latter shortPath is valid for ShowFileUsage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants