Remove Skija, prepare for truly MPP Skiko #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Aug 31, 2021
| import org.jetbrains.skija.impl.RefCnt | ||
| import org.jetbrains.skija.impl.Native | ||
| import org.jetbrains.skija.impl.Stats | ||
|
|
||
| class RuntimeEffect @ApiStatus.Internal constructor(ptr: Long) : RefCnt(ptr) { |
There was a problem hiding this comment.
Skija was designed that it exposes all private code as public, so if we forget to implement something, users can implement it themselves.
Do we want to change this rule?
There was a problem hiding this comment.
As we are both vendors and users of Skiko, not sure if this is relevant in our case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.