Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support vsync, refactor rendering, rendering tests #44

Merged
merged 13 commits into from
Jan 20, 2021
Merged

Support vsync, refactor rendering, rendering tests #44

merged 13 commits into from
Jan 20, 2021

Commits on Jan 15, 2021

  1. Configuration menu
    Copy the full SHA
    8866df9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c82039 View commit details
    Browse the repository at this point in the history
  3. FPSCounter

    igordmn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    b662436 View commit details
    Browse the repository at this point in the history
  4. Draw into picture, refactor SkiaLayer

    1. Split onRender into performUpdate and performDraw.
    performUpdate will be called from the Swing thread in upcoming commits (to avoid race conditions)
    
    2. Remove canvas.scale by default
    
    Motivation: automatic scaling is harmful.
    Example:
    - skiko returns us 100x100 canvas size.
    - We load image from disk and reduce its size to 100x100.
    - We draw this image onto canvas, and it is scaled 2x with artifacts.
    If skiko returns us 200x200 then we reduce image to 200x200 and draw it onto canvas without scaling.
    
    3. Cache contentScale
    It is expensive operation on Linux to do it in every frame (we read database)
    
    4. Remove onInit, onReshape, onDispose removed from SkiaRenderer.
    It is hard to implement it in the right thread (on macOs we have AppKit and AWT thread). Besides we don't use them in Compose.
    If they will be needed then we can implement them later.
    igordmn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    f970ae3 View commit details
    Browse the repository at this point in the history
  5. Support vsync

    igordmn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    620547a View commit details
    Browse the repository at this point in the history
  6. Screenshot based testing

    igordmn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    093421c View commit details
    Browse the repository at this point in the history
  7. SkiaWindow tests

    igordmn committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ef910e6 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Configuration menu
    Copy the full SHA
    1aecfc1 View commit details
    Browse the repository at this point in the history
  2. Vsync: review feedback

    igordmn committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    0a24e80 View commit details
    Browse the repository at this point in the history
  3. Fix SkiaPanel clipping

    igordmn committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    fa95723 View commit details
    Browse the repository at this point in the history
  4. Support Kotlin 1.3.72

    igordmn committed Jan 18, 2021
    Configuration menu
    Copy the full SHA
    38ae7bf View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Redrawer. Fix macOs issues

    igordmn committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    d56864e View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Configuration menu
    Copy the full SHA
    52efd98 View commit details
    Browse the repository at this point in the history