-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vsync, refactor rendering, rendering tests #44
Commits on Jan 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8866df9 - Browse repository at this point
Copy the full SHA 8866df9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c82039 - Browse repository at this point
Copy the full SHA 5c82039View commit details -
Configuration menu - View commit details
-
Copy full SHA for b662436 - Browse repository at this point
Copy the full SHA b662436View commit details -
Draw into picture, refactor SkiaLayer
1. Split onRender into performUpdate and performDraw. performUpdate will be called from the Swing thread in upcoming commits (to avoid race conditions) 2. Remove canvas.scale by default Motivation: automatic scaling is harmful. Example: - skiko returns us 100x100 canvas size. - We load image from disk and reduce its size to 100x100. - We draw this image onto canvas, and it is scaled 2x with artifacts. If skiko returns us 200x200 then we reduce image to 200x200 and draw it onto canvas without scaling. 3. Cache contentScale It is expensive operation on Linux to do it in every frame (we read database) 4. Remove onInit, onReshape, onDispose removed from SkiaRenderer. It is hard to implement it in the right thread (on macOs we have AppKit and AWT thread). Besides we don't use them in Compose. If they will be needed then we can implement them later.
Configuration menu - View commit details
-
Copy full SHA for f970ae3 - Browse repository at this point
Copy the full SHA f970ae3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 620547a - Browse repository at this point
Copy the full SHA 620547aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 093421c - Browse repository at this point
Copy the full SHA 093421cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef910e6 - Browse repository at this point
Copy the full SHA ef910e6View commit details
Commits on Jan 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1aecfc1 - Browse repository at this point
Copy the full SHA 1aecfc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a24e80 - Browse repository at this point
Copy the full SHA 0a24e80View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa95723 - Browse repository at this point
Copy the full SHA fa95723View commit details -
Configuration menu - View commit details
-
Copy full SHA for 38ae7bf - Browse repository at this point
Copy the full SHA 38ae7bfView commit details
Commits on Jan 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for d56864e - Browse repository at this point
Copy the full SHA d56864eView commit details
Commits on Jan 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 52efd98 - Browse repository at this point
Copy the full SHA 52efd98View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.