Raster #56
Raster #56
Conversation
| @@ -15,6 +15,7 @@ import kotlin.math.cos | |||
| import kotlin.math.sin | |||
|
|
|||
| fun main(args: Array<String>) { | |||
| // System.setProperty("skiko.renderApi", "RASTER") | |||
There was a problem hiding this comment.
Or maybe move to Gradle script in commented out form.
There was a problem hiding this comment.
I think it is better to remove this because this is only for software rendering testing.
| skijaState.apply { | ||
| canvas!!.clear(bleachConstant) |
There was a problem hiding this comment.
Does this code actually belongs to draw? Can we avoid reinit on every frame?
There was a problem hiding this comment.
To create a skia context, the OpenGL context must be current, so basically the first time we can create a skia context is inside the draw() method and we cannot initialize the skia context separately due to the macos CAOpenGLLayer update pipeline specific.
initContext performs only once, and all subsequent calls to the method simply return true.
| return when (renderApi) { | ||
| GraphicsApi.RASTER -> RasterContextHandler(layer) | ||
| GraphicsApi.OPENGL -> OpenGLContextHandler(layer) | ||
| GraphicsApi.METAL -> MetalContextHandler(layer) |
There was a problem hiding this comment.
Shalln't we throw an exception here?
There was a problem hiding this comment.
I decided to remove the METAL because it is not ready to use yet.
samples/SkijaInjectSample/src/main/kotlin/SkijaInjectSample/SkiaPanel.kt
Show resolved
Hide resolved
skiko/src/jvmMain/kotlin/org/jetbrains/skiko/PlatformOperations.kt
Outdated
Show resolved
Hide resolved
|
|
||
| val bytes = storage.readPixels(storage.getImageInfo(), (w * 4).toLong(), 0, 0) | ||
| if (bytes != null) { | ||
| val buffer = DataBufferByte(bytes, bytes.size) |
There was a problem hiding this comment.
Cannot we make custom buffer on top of storage to avoid intermediate bytes?
There was a problem hiding this comment.
I talking about that with Nikita and looks like we have for now only one way to get image data - via Bitmap.readPixels. I think there are several ways to get a common byte array for skia and awt rendering, but actually reading pixels is negligible compared to drawing (skia + awt). The best we could get is plus 0.5 frames per second. So i decided to do it later.
| @@ -1,5 +1,5 @@ | |||
| package org.jetbrains.skiko | |||
|
|
|||
| enum class GraphicsApi { | |||
| UNKNOWN, OPENGL, VULKAN, METAL | |||
| UNKNOWN, RASTER, OPENGL, D3D, VULKAN, METAL | |||
There was a problem hiding this comment.
Maybe names like SOFTWARE and DIRECT3D would be more descriptive.
No description provided.