Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows ARM support #610

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Windows ARM support #610

merged 2 commits into from
Nov 4, 2022

Conversation

igordmn
Copy link
Collaborator

@igordmn igordmn commented Oct 27, 2022

fixes #607

  • add skia.arch Gradle property. We set it to arm64 on CI to build a version for Windows ARM
  • change renderAPI fallback strategy (OpenGL doesn't work properly in Skia on Windows ARM)

Add skia.arch Gradle property.

We set it to `arm64` on CI to build a version for Windows ARM
@igordmn igordmn marked this pull request as ready for review November 2, 2022 16:56
@igordmn igordmn merged commit 87d5fb9 into master Nov 4, 2022
@igordmn igordmn deleted the windows-arm branch November 4, 2022 16:15
SergeevPavel pushed a commit that referenced this pull request Nov 7, 2022
* Windows ARM support

Add skia.arch Gradle property.

We set it to `arm64` on CI to build a version for Windows ARM

* Fix build
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this pull request Sep 29, 2023
Everything is already configured and battle tested on Toolbox, but we didn't call publication for Compose artifact itself.

The publication was configured in #322 and in JetBrains/skiko#610

Resolves https://youtrack.jetbrains.com/issue/COMPOSE-223/Finish-Windows-ARM-64-support
igordmn added a commit to JetBrains/compose-multiplatform that referenced this pull request Sep 29, 2023
…s-arm64 "helper" dependency for another users that use "compose.desktop.currentOs" DSL.

The publication was configured in JetBrains/compose-multiplatform-core#322 and in JetBrains/skiko#610

Resolves https://youtrack.jetbrains.com/issue/COMPOSE-223/Finish-Windows-ARM-64-support

TODO: Test Compose on a real Windows ARM64 machine
igordmn added a commit to JetBrains/compose-multiplatform that referenced this pull request Sep 29, 2023
Everything is already configured but we didn't publish desktop-windows-arm64 "helper" dependency for another users that use "compose.desktop.currentOs" DSL.

The publication was configured in JetBrains/compose-multiplatform-core#322 and in JetBrains/skiko#610

Resolves https://youtrack.jetbrains.com/issue/COMPOSE-223/Finish-Windows-ARM-64-support

TODO: Test Compose on a real Windows ARM64 machine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Windows ARM64
2 participants