DirectX rendering implementation. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olonho
reviewed
Feb 16, 2021
skiko/build.gradle.kts
Outdated
| @@ -380,7 +381,10 @@ tasks.withType(LinkSharedLibrary::class.java).configureEach { | |||
| "Dwmapi.lib", | |||
| "opengl32.lib", | |||
| "shcore.lib", | |||
| "user32.lib" | |||
| "user32.lib", | |||
| "d3d12.lib", | |||
There was a problem hiding this comment.
Does it mean we must have dx12 dlls on the target system?
There was a problem hiding this comment.
As far as I understand, the new graphics card drivers contain the d3d12 library, but depending on the OS and D3D_FEATURE_LEVEL_11_0 may create a DirectX12 or DirectX11 context. But I cannot verify this yet. The best solution is to test this on Windows 8 / 8.1 because Microsoft has released DirectX12 support on Windows 7.
olonho
reviewed
Feb 16, 2021
olonho
reviewed
Feb 16, 2021
olonho
reviewed
Feb 16, 2021
olonho
reviewed
Feb 16, 2021
olonho
reviewed
Feb 16, 2021
skiko/src/jvmMain/kotlin/org/jetbrains/skiko/SkikoProperties.kt
Outdated
Show resolved
Hide resolved
olonho
reviewed
Feb 16, 2021
skiko/src/jvmMain/kotlin/org/jetbrains/skiko/context/Direct3DContextHandler.kt
Outdated
Show resolved
Hide resolved
olonho
reviewed
Feb 16, 2021
skiko/src/jvmMain/kotlin/org/jetbrains/skiko/context/Direct3DContextHandler.kt
Show resolved
Hide resolved
igordmn
reviewed
Feb 16, 2021
skiko/src/jvmMain/kotlin/org/jetbrains/skiko/redrawer/Direct3DRedrawer.kt
Show resolved
Hide resolved
skiko/src/jvmMain/kotlin/org/jetbrains/skiko/context/Direct3DContextHandler.kt
Outdated
Show resolved
Hide resolved
olonho
reviewed
Feb 16, 2021
…eachabilityFence.
igordmn
reviewed
Feb 19, 2021
igordmn
reviewed
Feb 19, 2021
igordmn
reviewed
Feb 19, 2021
igordmn
reviewed
Feb 19, 2021
igordmn
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DirectX rendering support.