Fix LineMetrics resolution for wasm and js targets #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contributes to fixing https://youtrack.jetbrains.com/issue/COMPOSE-108/CfW-fix-TextField-cursor I had to introduce assertCloseEnough sensitive enought to path throughout all our targets
dima-avdeev-jb
approved these changes
Dec 14, 2023
eymar
reviewed
Dec 14, 2023
skiko/src/commonTest/kotlin/org/jetbrains/skia/ParagraphTest.kt
Outdated
Show resolved
Hide resolved
skiko/src/commonTest/kotlin/org/jetbrains/skia/ParagraphTest.kt
Outdated
Show resolved
Hide resolved
eymar
reviewed
Dec 14, 2023
| baseline = 13.619318008422852, | ||
| lineNumber = 0 | ||
| ), epsilon = lineMetricsEpsilon | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
now it's a redundant '}' so it doesn't compile
eymar
reviewed
Dec 14, 2023
skiko/src/commonTest/kotlin/org/jetbrains/skia/util/assertCloseEnough.kt
Outdated
Show resolved
Hide resolved
eymar
approved these changes
Dec 15, 2023
|
is this fix in version "1.6.0-beta01" ? |
@dhakehurst I see it was fixed in 1.6.0-beta02. |
eymar
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this pull request
May 1, 2024
The issue JetBrains/compose-multiplatform#4078 was fixed earlier. Probably in skiko: JetBrains/skiko#846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contributes to fixing https://youtrack.jetbrains.com/issue/COMPOSE-108/CfW-fix-TextField-cursor
I had to introduce assertCloseEnough sensitive enought to path throughout all our targets
Fixes JetBrains/compose-multiplatform#3120