Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Wepack 4 #248

Closed
denisw opened this issue Feb 21, 2018 · 3 comments
Closed

Not compatible with Wepack 4 #248

denisw opened this issue Feb 21, 2018 · 3 comments

Comments

@denisw
Copy link

denisw commented Feb 21, 2018

This plugin doesn't seem to work with Webpack 4.0.0-beta.2 at the moment. I get the following error:

Module build failed: TypeError: Cannot read property 'target' of undefined
    at configurator (/Users/denis/Dropbox/Workspace/yumory/web/node_modules/svg-sprite-loader/lib/configurator.js:18:34)
    at Object.loader (/Users/denis/Dropbox/Workspace/yumory/web/node_modules/svg-sprite-loader/lib/loader.js:37:18)
 @ ./src/common/NavBar.js 27:16-50
 @ ./src/recipes/RecipeDetailsPage.js
 @ ./src/App.js
 @ ./src/index.js
 @ multi (webpack)-dev-server/client?http://localhost:3000 webpack/hot/dev-server ./src

This might be caused by one of the breaking changes for plugin authors described here:

https://github.com/webpack/webpack/releases/tag/v4.0.0-beta.0

@denisw denisw changed the title Wepack 4 compatibility Not compatible with Wepack 4 Feb 21, 2018
@Hypnosphi
Copy link

@kisenka See official migration guide for loader developers https://medium.com/webpack/webpack-4-migration-guide-for-plugins-loaders-20a79b927202

@Chris2011
Copy link

Have the same problem, just voted for it. Only want to know, is there a workaround for this? Except from downgrade Webpack :D

phun-ky pushed a commit to phun-ky/svg-sprite-loader that referenced this issue Feb 27, 2018
@ryanclark
Copy link
Contributor

Started work in #247. @phun-ky has continued this on in #249.

Hopefully will land soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants