Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement storing session after restarting VSCode IDE. #11

Closed
rugpanov opened this issue Jul 7, 2017 · 9 comments
Closed

Implement storing session after restarting VSCode IDE. #11

rugpanov opened this issue Jul 7, 2017 · 9 comments

Comments

@rugpanov
Copy link
Contributor

rugpanov commented Jul 7, 2017

The extension should store session even after restarting VSCode.
We should implement storing user credentials on a disk.

@rugpanov rugpanov added the vscode label Jul 7, 2017
@rugpanov rugpanov self-assigned this Jul 7, 2017
@rugpanov
Copy link
Contributor Author

According to microsoft/vscode#30209 and microsoft/vscode#15414 Microsoft are planning to provide a secure credential storage API in the near future. From the same thread: "VSTS Build Status extension stores password in settings currently, which is not secure." .

From my perspective there are two approach: don't provide any storage till Microsoft provides any secure one OR we can implement an insecure storage and then replace it by secure when it's possible. @dtretyakov, what is your opinion?

@dtretyakov
Copy link
Collaborator

@rugpanov, we could try to leverage https://github.com/atom/node-keytar to store credentials until VSCode will bring own credentials store.

@rugpanov
Copy link
Contributor Author

@dtretyakov, I was looking at this module, but it requires python on user's PC. We discussed this problem with Igor and then I decided not to use it. I am afraid because of this problem we cannot use levelUp as well.

@dtretyakov
Copy link
Collaborator

@rugpanov, you could take a look at the keytar with prebuild binaries, produced by our colleague: https://www.npmjs.com/package/keytar-prebuild

@rugpanov
Copy link
Contributor Author

rugpanov commented Jul 27, 2017

@dtretyakov, During installing by "npm install keytar-prebuild --arch=ia32" I got an error: "Can't find Python executable "python", you can set the PYTHON env variable." again.

@rugpanov
Copy link
Contributor Author

New error for Win10:

A dynamic link library (DLL) initialization routine failed.

I've fount an closed issue: atom/node-keytar#51, but:

npm install keytar --save-dev electron-rebuild --arch=ia32

doesn't work for me as well.

@dtretyakov
Copy link
Collaborator

The discussion regarding Credentials API in VS Code: microsoft/vscode#31131

@ehaackXceligent
Copy link

Just a thought: (At least with .0.0.2,) it is storing the Tc URL, username... just not the password.

I don't think it's too much to ask for devs to re-enter their Tc password on restart.

@rugpanov
Copy link
Contributor Author

rugpanov commented Jan 19, 2018

Fixed at ec6ea4b .
Now the extension can store user credentials. At 0.0.3 to enable this feature user should set a teamcity.credentials.persistent: true setting option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants