Swift 4.2 #1
Merged
Swift 4.2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove space in name of Test Helpers subspec
When using the banner in iOS7 an additional `layoutIfNeeded()` call is required as iOS7 doesn't handle this internally. The exception this resolves is: ``` Auto Layout still required after executing -layoutSubviews. Banner's implementation of -layoutSubviews needs to call super. ```
Add option to show banner at the top or bottom
Fix for iOS7
Swift 2.2 new selector style
…OS 10 (bryx-inc#52) * Updated for Xcode 8 Beta 6 * Fixed incorrect animation behaviour on iOS 10 * Converted to Swift 3 syntax * Added comment explaining why the #available block is necessary * Fixed incoherent identation * Improved code readability * Removed superfluous -layoutIfNeeded call
* Shared scheme for Carthage fix * Added Pods back to fix Carthage Support * Deployment target 7.0 * Deployment target 7.0
* Fixing deployment target of pod project to allow submission to iTunes Connect * Fixing other deployment target for pod project * Fixing the project specific deployment target
* Adding the ability to change the height of the banner * Changing property name to minimumHeight
In case that an app has more than one UIWindow with windowLevel equal to UIWindowLevelNormal, this topWindow() method won’t find the right one. Signed-off-by: Pablo Romero <promero@carecloud.com>
Instead of using leading and trailing constraints to the superview, specify that the widths should be equal. With this change, the width of the notification will match that of the table view.
Resolves issue bryx-inc#24 - Wrong width Thanks Bennett -- good catch!
* Swift 4 migration: adds @objc keywords * Swift 4 migration: moves nil fallback on show-method into function to avoid exposing topWindow method. Otherwise the compiler complains about being unable to use the internal topWindow method as parameter default value * Adds nil default parameter to method signature, to ensure method can be called without a passed view
Updates version and swift_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift 4.2 update.