Aether theme distro logo selection won't work in both web-greeter and nody-greeter #1
Comments
|
@JezerM, a very Happy New Year, please have a look here, whenever you get time. |
|
Oh, sorry, I had notifications turned off. Merry Christmas and Happy New Year! I'll check what's the problem, soon~ |
|
I cannot reproduce this issue, Aether works on both web-greeter and nody-greeter without any (relevant) issue. In nody-greeter v1.2.1: (background and icon changed)
In web-greeter v3.2.1: (background and icon changed)
The icon should be instantly changed without needing to save, as the configuration is applied instantly; the "save" button just saves the configuration. So, it's weird that it isn't happening on web-greeter. About nody-greeter, this could be due to a |
|
Greetings @JezerM ! |
|
Hi, I created a branch to fix this. Do a pull from "#1-fix" branch, build with It should be similar to this:
|
|
Hello @JezerM Thank you for helping |
|
Everything is done in the Aether root directory. Do a pull and switch to "#1-fix" branch, then cd /path/to/Aether
git pull
git switch "#1-fix"
npm run build
nody-greeter --debug --theme index.html |
I think you don't need to run |
|
|
|
Well, Aether is normally pre-compiled when you do a pull, but not this time. So you'd need to run: npm install
npm run buildIf this is an inconvenient, just tell me to build Aether and push. |
|
Oh, thanks, What should I do now? I might not be able to reply to you now. It's getting late in India, and I am still young and might get scolded if I don't go to bed now. 😅 Sorry for the inconvience |
|
No problem, though sudo is not necessary when doing git pull
nody-greeter ––debug ––theme index.htmlThe error seems like connection problems maybe. |
|
I hope this was what you were asking for. Thank you for you time |
|
Yep, that's what I was asking for, and it's weird. Seems like there is nothing inside |
|
The problem was that you were using symbolic links as a theme and therefore nody-greeter was trying to read inside the real path, but nody-greeter did allow the symlink path instead, which provoked it to be rejected. It should be fixed now in nody-greeter, just do a About web-greeter, I still don't know why the distro-logo isn't being updated; I ask you to provide a screenshot doing the same as before but with |
Thanks @JezerM, but I am getting error, while updating node-greeter, I even tried reinstalling it, but no luck |
|
You need to install some dependencies:
And then build again. |
|
Again did a fresh clone of nody-greeter, were already installed in my system. This one is from Void: |
|
It should be fixed now (I hope so), just pull, build and install. |
|
Greetings @JezerM
Now the wallpaper issue has been solved, and there are logos in the list, in nody-greeter. Both web-greeter and nody-greeter have the same issues now, with aether: the logo won't apply to the login screen. I tried web-greeter: nody-greeter: Thank you |
|
In web-greeter, you can open the DevTools with So, about the distro logo, when you do change the logo, does it prints something in the console? It should. |
|
web-greeter:
@JezerM, please have a look. |
|
Hmm, the distro logo inside the Login sidebar is not reacting to the changes, I'll have to look at it. |
|
About the nody-greeter reinstall, I did push a commit which should fix the paths with special character problems, so you could build it inside your "Source Packages" directory. In Void Linux, remember to install the Also, do not build without compiling the typescript files before: npm install
npx tsc --build
node make build
sudo node make installMake sure that |
System is up to date Still the same problems! Are you planning to create flatpaks for nody and web greeters? |
|
Yeah, Also, I've found where's the distro logo issue, so it should be fixed soon. About flatpaks, I still need to learn about them, but it's in my plans. |
|
It worked! 👏 |
|
Glad it worked! Thanks for all your time and not giving up on this, really helps~ |
|
Greetings @JezerM, Can you run Lightdm with KDE? I have Garuda Linux, which is basically Arch, with KDE. Thank you |
I guess I could add those icons~
It should work, but you can't run LightDM itself in KDE, as lightdm runs in an standalone x11 server. However, |
Ya pnpm was something else; installing it worked before because it had nodejs as a dependency. I uninstalled pnpm and reinstalled nodejs, which solved the issue in Void Linux! |
|
@austinrojers The void-linux logotype was added~ About Fedora's logotype, it's a trademark and has its usage guidelines, so it would require a permission to use. I don't know if I can obtain it for this purpose, but I could try. |
Expected behavior
Normally, you should be able to select a distro logo of choice, and it gets applied to the login screen on clicking save.
Actual behavior
I case of web-greeter:
I am able to select a logo of choice and get a preview, as you can see above. but clicking on save won't apply it on the login screen
In case of nody-greeter:
there are no logos on the list
And in nody-greeter, when I try to change the background, it gives me a blank background instead, as in the above picture
Additional context
There are no errors when run in debug mode:
Thank you, and Merry Christmas 🎅
The text was updated successfully, but these errors were encountered: