Fix version diff word detection #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jguer
reviewed
Apr 18, 2023
| "github.com/Jguer/yay/v12/pkg/text" | ||
| ) | ||
|
|
||
| func TestVersionDiff(t *testing.T) { |
There was a problem hiding this comment.
I think you have to force text.Color = true and then unset it at the end of the test to stop the automatic tty detection from turning off colors.
One of the unfortunate places where we haven't gotten rid of globals
There was a problem hiding this comment.
Added the change.
Jguer
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempted Fix for #1961
The core problem is the
checkWordsfunction.e.g while traversing through
arch, it findsrcas well. Thereby goes off by 1.I have added some tests and changed the
checkWordsto return true only if the current character is not a Letter (i.e not part of a bigger word).Other tests are also passing.