Count from 1 instead of 0 when searching packages #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel like starting from 1 is much better ergonomically while not using a numpad. This could be added as a config option instead if you would prefer.
|
Over time I got used to this, but I remember being confused and uncomfortable with yay starting indexes from zero, so I support this change. Config is probably an overkill for this :) |
|
@maximbaz I'm away from my dev environment at the moment, can you test that this patch does not create any conflicts and selects the right package on searches containing only AUR, only repo and AUR and repo? Otherwise I'll only be able to review it in 7 days. |
|
When I submitted this I tested:
All seemed to work as expected. |
|
Testing now, will get back in a few moments. |
|
Works well in all 3 cases, the patch itself looks good to me too. |
|
I forgot to mention I also did test all these cases on both --bottomup and --topdown. so it should be good for those too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like starting from 1 is much better ergonomically while not using
a numpad. This could be added as a config option instead if you would
prefer.