Skip to content

Commit

Permalink
fix: #1149 modifying media frames inside ".__se__tag"
Browse files Browse the repository at this point in the history
  • Loading branch information
JiHong88 committed Jan 27, 2023
1 parent 468afe6 commit 13a4935
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/plugins/dialog/audio.js
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,9 @@ export default {
const container = this.plugins.component.set_container.call(this, cover, 'se-audio-container');

try {
if (this.util.isListCell(existElement)) {
if (this.util.getParentElement(prevElement, this.util.isNotCheckingNode)) {
prevElement.parentNode.replaceChild(container, prevElement);
} else if (this.util.isListCell(existElement)) {
const refer = this.util.getParentElement(prevElement, function (current) { return current.parentNode === existElement; });
existElement.insertBefore(container, refer);
this.util.removeItem(prevElement);
Expand Down
4 changes: 3 additions & 1 deletion src/plugins/dialog/image.js
Original file line number Diff line number Diff line change
Expand Up @@ -772,7 +772,9 @@ export default {
contextImage._element :
/^A$/i.test(contextImage._element.parentNode.nodeName) ? contextImage._element.parentNode : this.util.getFormatElement(contextImage._element) || contextImage._element;

if (this.util.isListCell(existElement)) {
if (this.util.getParentElement(contextImage._element, this.util.isNotCheckingNode)) {
contextImage._element.parentNode.replaceChild(container, contextImage._element);
} else if (this.util.isListCell(existElement)) {
const refer = this.util.getParentElement(contextImage._element, function (current) { return current.parentNode === existElement; });
existElement.insertBefore(container, refer);
this.util.removeItem(contextImage._element);
Expand Down
4 changes: 3 additions & 1 deletion src/plugins/dialog/video.js
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,9 @@ export default {
if (format) contextVideo._align = format.style.textAlign || format.style.float;
this.plugins.video.setAlign.call(this, null, oFrame, cover, container);

if (this.util.isListCell(existElement)) {
if (this.util.getParentElement(prevFrame, this.util.isNotCheckingNode)) {
prevFrame.parentNode.replaceChild(container, prevFrame);
} else if (this.util.isListCell(existElement)) {
const refer = this.util.getParentElement(prevFrame, function (current) { return current.parentNode === existElement; });
existElement.insertBefore(container, refer);
this.util.removeItem(prevFrame);
Expand Down

0 comments on commit 13a4935

Please sign in to comment.