fix: #336 check components

delete core-fileInfoPlugins
JiHong88 · May 6, 2020 · d55134d · d55134d
1 parent 348b4bd
commit d55134d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 19 deletions.
diff --git a/sample/html/out/document-editor.html b/sample/html/out/document-editor.html
@@ -546,16 +546,6 @@ <h4 class="name" id="activePlugins"><span class="type-signature"></span>activePl
             <dl class="details"></dl>
 
 
-            <h4 class="name" id="fileInfoPlugins"><span class="type-signature"></span>fileInfoPlugins<span
-                    class="type-signature"></span></h4>
-            <div class="description">
-                Plugins array with "checkFileInfo" and "resetFileInfo" methods.<br>
-                "fileInfoPlugins" runs the "add" method when creating the editor.<br>
-                "checkFileInfo" method is always call just before the "change" event.
-            </div>
-            <dl class="details"></dl>
-
-
             <h4 class="name" id="commandMap"><span class="type-signature"></span>commandMap<span
                     class="type-signature"></span></h4>
             <div class="description">
@@ -1988,7 +1978,6 @@ <h3>core</h3>
         <li><a href="document-editor.html#pasteTagsWhitelistRegExp">pasteTagsWhitelistRegExp</a></li>
         <li><a href="document-editor.html#hasFocus">hasFocus</a></li>
         <li><a href="document-editor.html#activePlugins">activePlugins</a></li>
-        <li><a href="document-editor.html#fileInfoPlugins">fileInfoPlugins</a></li>
         <li><a href="document-editor.html#commandMap">commandMap</a></li>
         <li><a href="document-editor.html#_variable">_variable</a></li>
         <li><b>Methods</b></li>

diff --git a/src/lib/core.js b/src/lib/core.js
@@ -287,11 +287,21 @@ export default function (context, pluginCallButtons, plugins, lang, options, _ic
         activePlugins: null,
 
         /**
-         * @description Plugins array with "checkFileInfo" and "resetFileInfo" methods.
+         * @description Array of "checkFileInfo" functions with the core bound
+         * (Plugins with "checkFileInfo" and "resetFileInfo" methods)
          * "fileInfoPlugins" runs the "add" method when creating the editor.
          * "checkFileInfo" method is always call just before the "change" event.
+         * @private
+         */
+        _fileInfoPluginsCheck: null,
+
+        /**
+         * @description Array of "resetFileInfo" functions with the core bound
+         * (Plugins with "checkFileInfo" and "resetFileInfo" methods)
+         * "checkFileInfo" method is always call just before the "functions.setOptions" method.
+         * @private
          */
-        fileInfoPlugins: null,
+        _fileInfoPluginsReset: null,
 
         /**
          * @description Variables for file component management
@@ -4193,8 +4203,8 @@ export default function (context, pluginCallButtons, plugins, lang, options, _ic
          * @private
          */
         _checkComponents: function () {
-            for (let i in this.fileInfoPlugins) {
-                this.fileInfoPlugins[i].checkFileInfo.call(this);
+            for (let i in this._fileInfoPluginsCheck) {
+                this._fileInfoPluginsCheck[i]();
             }
         },
 
@@ -4203,8 +4213,8 @@ export default function (context, pluginCallButtons, plugins, lang, options, _ic
          * @private
          */
         _resetComponents: function () {
-            for (let i in this.fileInfoPlugins) {
-                this.fileInfoPlugins[i].resetFileInfo.call(this);
+            for (let i in this._fileInfoPluginsReset) {
+                this._fileInfoPluginsReset[i]();
             }
         },
 
@@ -4292,9 +4302,12 @@ export default function (context, pluginCallButtons, plugins, lang, options, _ic
                 INDENT: context.tool.indent
             };
 
+            // file components
+            this._fileInfoPluginsCheck = [];
+            this._fileInfoPluginsReset = [];
+
             // Command and file plugins registration
             this.activePlugins = [];
-            this.fileInfoPlugins = [];
             this._fileManager.tags = [];
             this._fileManager.pluginMap = {};
 
@@ -4308,7 +4321,8 @@ export default function (context, pluginCallButtons, plugins, lang, options, _ic
                 }
                 if (typeof plugin.checkFileInfo === 'function' && typeof plugin.resetFileInfo === 'function') {
                     this.callPlugin(key, null, button);
-                    this.fileInfoPlugins.push(plugin);
+                    this._fileInfoPluginsCheck.push(plugin.checkFileInfo.bind(this));
+                    this._fileInfoPluginsReset.push(plugin.resetFileInfo.bind(this));
                 }
                 if (plugin.fileTags) {
                     this.callPlugin(key, null, button);