Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify icon style #215

Closed
natanielcz opened this issue Feb 12, 2020 · 6 comments
Closed

Unify icon style #215

natanielcz opened this issue Feb 12, 2020 · 6 comments
Labels
Milestone

Comments

@natanielcz
Copy link

I think all icons should look like those which are bolder.

image

@MRB60
Copy link

MRB60 commented Feb 12, 2020

Perhaps high jacking the subject but...
Not imminent for me but I agree it would be nice to be able to customize the icons used, both for style but also for adding missing ones (e.g. for custom plugins).
And it is.
By modifying font and css folder under assets, you can generate any fonts/icons you want.

Perhaps a short instruction how to generate other icons (and fonts) could be prepared...

@JiHong88
Copy link
Owner

Hi, @natanielcz @MRB60
The icons are svg merge file created from https://glyphter.com/.
I wanted to match the border width of all the icons,
But, I can't found icons to replace the "Regular icons" :(

@MRB60
Copy link

MRB60 commented Feb 13, 2020

@JiHong88 ,
What do you mean that you cannot find icons to replace regular icons?
Not even by https://materialdesignicons.com/ ?

@JiHong88
Copy link
Owner

@MRB60
Sorry for the confusion.
That reply about comment of @natanielcz

I didn't know a materialdesignicons.com.
It looks good.
It may be better to use "inline svg" in the editor than web fonts. #206

@MRB60
Copy link

MRB60 commented Feb 13, 2020

Ok,
I agree that inline svg fonts/icons is probably more efficient for core and basic plugins.
However, it would be nice to find a generic solution for future plugins (and custom plugins) where new icons would be needed - either by extending existing font/icons used "inline" (thus an instruction how to extend) or allowing to include fonts/icons as web font.

@JiHong88
Copy link
Owner

The 2.27.0 version has been updated.
If there is an issue, please register as a new issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants