Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined error when try to apply/remove style to/from already styled selection #297

Closed
LexaGal opened this issue Mar 26, 2020 · 2 comments
Closed

undefined error when try to apply/remove style to/from already styled selection #297

LexaGal opened this issue Mar 26, 2020 · 2 comments
Labels
bug enhancement
Milestone
2.28.1

Comments

@LexaGal
Copy link

LexaGal commented Mar 26, 2020

ScreenshtErr

ScreenshtErr1

The issue happens at times but with any style tag (strong, ins, span, ...). Seem to be a text parsing bug.
@JiHong88
Copy link
Owner

The editor must have a format tag (P, DIV..).
I'll improve the consistency check before rendering the HTML in the editor.
Thank you.

@JiHong88 JiHong88 added this to the 2.28.1 milestone Mar 27, 2020
@JiHong88 JiHong88 mentioned this issue Mar 27, 2020
Closed
@JiHong88 JiHong88 added this to In progress in suneditor Mar 27, 2020
@JiHong88 JiHong88 moved this from In progress to Next update in suneditor Mar 27, 2020
@JiHong88 JiHong88 moved this from Next update to In progress in suneditor Mar 27, 2020
@JiHong88 JiHong88 moved this from In progress to Working list in suneditor Mar 27, 2020
@JiHong88 JiHong88 moved this from Working list to In progress in suneditor Mar 27, 2020
@JiHong88 JiHong88 moved this from In progress to Working list in suneditor Mar 27, 2020
JiHong88 added a commit that referenced this issue Mar 29, 2020
@JiHong88
fix: #292 #297 #299 #302
918ec86 
improve the HTML consistency check, paste behavior,
add: core-nativeFocus, util-isTextStyleElement,
improved: cleanHTML, convertContentsForEditor,
improved: insertNode, removeNode, insertHTML
@JiHong88 JiHong88 moved this from Working list to Review in progress in suneditor Mar 29, 2020
suneditor automation moved this from Review in progress to Done Mar 29, 2020
@JiHong88
Copy link
Owner

JiHong88 commented Apr 2, 2020

The 2.28.1 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.

@JiHong88 JiHong88 removed this from Done in suneditor Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
2.28.1
Development

No branches or pull requests
2 participants
@LexaGal @JiHong88