Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single quote becomes double quote after source view. #335

Closed
rwaldron opened this issue Apr 14, 2020 · 1 comment
Closed

Single quote becomes double quote after source view. #335

rwaldron opened this issue Apr 14, 2020 · 1 comment

Comments

@rwaldron
Copy link
Contributor

This can be demonstrated here: http://suneditor.com/sample/html/examples.html

  1. Type this into the first example: What's happening??
  2. Hit the </> icon to see source view
  3. Hit the icon again to return to rendered view.

The string will now be What"s happening??. The reason this is happening is because single quote is being turned into the entity &quot;, but should be &apos;
@rwaldron
Copy link
Contributor Author

The bug is here: https://github.com/JiHong88/SunEditor/blob/73d5e70b65ac09e6838fccec06f33684bef35b0a/src/lib/util.js#L39-L41

JiHong88 added a commit that referenced this issue Apr 17, 2020
@JiHong88
Merge pull request #337 from rwaldron/fix-html-apos-entity
fffc96f 
Bug: correct conversion of quotes: single quote -> &apos;, double quote -> &quot;. Fixes gh-335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rwaldron