Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create link move selected text to end of paragraph #584

Closed
rexpan opened this issue Dec 26, 2020 · 3 comments
Closed

Create link move selected text to end of paragraph #584

rexpan opened this issue Dec 26, 2020 · 3 comments
Labels
bug
Milestone
2.36.0

Comments

@rexpan
Copy link

rexpan commented Dec 26, 2020 •
edited

  1. With this HTML content
<p><span>using the OAuth <a href="http://suneditor.com/sample/index.html" target="">signing </a>process. Google</span><br>
</p>
  1. Select the OAuth signing process. (select range should include the <a> link)
  2. Create link with any URL
  3. Result: created new link with selected range but moved to end of paragraph.

f3s2w6kmaE
@JiHong88 JiHong88 added the bug label Dec 27, 2020
@JiHong88 JiHong88 added this to the 2.35.0 milestone Dec 27, 2020
JiHong88 added a commit that referenced this issue Jan 11, 2021
@JiHong88
fix: #584 core.insertNode
49a2510
@JiHong88
Copy link
Owner

The 2.35.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.

@rexpan
Copy link
Author

rexpan commented Jan 22, 2021

Thank you for your fix. The issue has been fixed for selected text inside the the paragraph.
But this issue is still reproduce if you select to begin of the paragraph.

QEDVpzNJqm

@JiHong88 JiHong88 modified the milestones: 2.35.0, 2.35.2 Jan 22, 2021
@JiHong88 JiHong88 reopened this Jan 22, 2021
JiHong88 added a commit that referenced this issue Jan 22, 2021
@JiHong88
fix: #584 core.insertNode
901bc69
JiHong88 added a commit that referenced this issue Jan 23, 2021
@JiHong88
fix: #584 core.insertNode
f4904e2
@JiHong88
Copy link
Owner

The 2.36.0 version has been updated.
If this issue has not been resolved, please reopen this issue.
Thank you.

NickyTope pushed a commit to isw-kudos/SunEditor that referenced this issue Feb 11, 2021
@JiHong88 @NickyTope
fix: JiHong88#584 core.insertNode
9e4e158
NickyTope pushed a commit to isw-kudos/SunEditor that referenced this issue Feb 11, 2021
@JiHong88 @NickyTope
fix: JiHong88#584 core.insertNode
eb75d64
NickyTope pushed a commit to isw-kudos/SunEditor that referenced this issue Feb 11, 2021
@JiHong88 @NickyTope
fix: JiHong88#584 core.insertNode
173d725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.36.0
Development

No branches or pull requests
2 participants
@rexpan @JiHong88