Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent audio source reset in disabled mode #1276

Conversation

SystemChanger
Copy link
Contributor

@SystemChanger SystemChanger commented Jul 15, 2023

Suneditor in disabled (read-only) mode.

Before:
suneditor fix audio onInput (before)

After:
suneditor fix audio onInput (after)

P.S. @JiHong88 Another solution was to add e.stopPropagation() to audio element onInput(e) on its creation, but I thought that in the future this problem may affect other plugins, or we may need to handle some events in onInput_wysiwyg, so I decided to place handler in onInput_wysiwyg. You may reconsider it ;)
P.P.S. Cool 'editMode' button I have, don't you think so? ;)

@JiHong88
Copy link
Owner

JiHong88 commented Jan 3, 2024

@SystemChanger Sorry, for the late reply.
First of all thanks for your contribution.
I checked too late.
This is a really useful.
Can you please re request PR at current master version?
All PR are conflicting with the master version.

@JiHong88 JiHong88 added this to the 2.45.2 milestone Apr 7, 2024
@JiHong88 JiHong88 closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants