Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript #311

Merged
merged 2 commits into from
Apr 4, 2020
Merged

Typescript #311

merged 2 commits into from
Apr 4, 2020

Conversation

tswistak
Copy link
Contributor

@tswistak tswistak commented Apr 4, 2020

Hi,

I think it covers 99% of SunEditor use cases in TypeScript.

  1. I've reverted d.ts files you've deleted. Though they are not imported directly by the user, it allowed to split typings code into smaller parts. And we need them, because whole functionality is inside lib/core. We can merge everything into one file (like index.d.ts) but it would be hard to maintain manually.
  2. In some cases I couldn't guess the type, so I've left any with TODO comment.
  3. To consider - maybe we don't need full typing for Lang, maybe just Record<string, string> would be enough.

Cheers!

@JiHong88 JiHong88 merged commit eb47086 into JiHong88:master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants