Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If option.imageFileInput is false .se-dialog-files-remove will not exist #357

Closed
wants to merge 1 commit into from

Conversation

purphoros
Copy link

Have been using suneditor-react and tried to use option imageFileInput: false which resulted in Cannot read property 'addEventListener' of null

Add validation if querySelector can find .se-dialog-files-remove

@JiHong88
Copy link
Owner

JiHong88 commented May 3, 2020

Hi @purphoros
First, Thank you for your contribution :)
But this issue is fixed.
I'll reject this PR to prevent code conflicts.
I'll update version and notify you within this week.
Thank you!

@JiHong88 JiHong88 closed this May 3, 2020
@JiHong88
Copy link
Owner

JiHong88 commented May 8, 2020

@purphoros
The 2.29.0 version has been updated.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants