Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Johor.json #8

Merged
merged 6 commits into from
Oct 16, 2021
Merged

Added Johor.json #8

merged 6 commits into from
Oct 16, 2021

Conversation

saravananselvamohan
Copy link
Contributor

@saravananselvamohan saravananselvamohan commented Oct 15, 2021

#6 Added Johor.json
#4 Added Kedah.json

Added entries for all federal territories to all.json
Added details for Johor State
Added Kedah.json
@JianLoong
Copy link
Owner

Hi @saravananselvamohan , please make sure the Kedah.json is a valid JSON file. It seems there are still double quotes present in the description string making it an invalid JSON file.

Updated valid JSON format
@saravananselvamohan
Copy link
Contributor Author

@JianLoong Thanks for the valid review. Updated the changes

Added Negeri_Sembilan.json
@saravananselvamohan
Copy link
Contributor Author

#9 Added Negeri_Sembilan.json

@JianLoong JianLoong merged commit a88e413 into JianLoong:main Oct 16, 2021
@JianLoong
Copy link
Owner

Looks good! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants