Bring NCO update back #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JianpingHuang-NOAA
approved these changes
Feb 24, 2024
JianpingHuang-NOAA
merged commit d06101c
into
JianpingHuang-NOAA:feature/AQMv7_release_v13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back changes from NCO:
-EXTRN_MDL_DATA_STORES='hpss aws nomads'
+EXTRN_MDL_DATA_STORES=''
+#EXTRN_MDL_DATA_STORES='hpss aws nomads'
These options cause make_ics/make_lbcs look for external sources and takes 15-30 minutes to fail. EXTRN_MDL_DATA_STORES should be blank so it only looks for the files on WCOSS and fails immediately if not found.
-DCOMINfire='/lfs/h1/ops/prod/dcom'
+#DCOMINfire='/lfs/h1/ops/prod/dcom'
-DCOMINairnow='/lfs/h1/ops/prod/dcom'
+#DCOMINairnow='/lfs/h1/ops/prod/dcom'
These overwrite variables set in J-jobs so I commented them out. We also should not have hard-coded path locations.
Use '-s' instead of '-f' to prevent size zero file:
ush/bash_utils/get_manage_externals_config_property.sh:115: if [ ! -f "${externals_cfg_fp}" ]; then
ush/bash_utils/create_symlink_to_file.sh:122: if [ ! -f "${target}" ]; then
scripts/exaqm_make_lbcs.sh:408:if [ ! -f "${exec_fp}" ]; then
scripts/exaqm_make_ics.sh:491:if [ ! -f "${exec_fp}" ]; then
scripts/exaqm_lbcs.sh:109: if [ -f ${chem_lbcs_fp} ]; then
scripts/exaqm_lbcs.sh:120: if [ -f "$1" ]; then
scripts/exaqm_lbcs.sh:274: if [ ! -f "${exec_fp}" ]; then
Update ecflow definition for 18Z time based trigger.