Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing about the ComputeNormlizedSGD #3

Open
yyangzh opened this issue Jul 10, 2020 · 4 comments
Open

Confusing about the ComputeNormlizedSGD #3

yyangzh opened this issue Jul 10, 2020 · 4 comments

Comments

@yyangzh
Copy link

yyangzh commented Jul 10, 2020

Hi,
sorry for the bothering,

I'm confused about the function ComputeNormlizedSGD( F1, F2, size1, size2).
In this function, symmetric computation is applied.
However, when you reverse the direction from I1->I2 to I2->I1, should the fundamental F1, F2 be changed to their transposed one F1^T, F2^T?
In your function, d2 = one_iteration(F2, F1, h2, w2, h1, w1) and I can't understand why there is no such transformation.

I'm looking forward to your kindly reply :).

@JiawangBian
Copy link
Owner

Thanks for your attention on this work. So sorry that as I haven't read this code for a long time, it is hard for me to answer your questions quickly. However, I am confident that it is correct, as I paid much time on checking them at that moment. I hope that you try to read it more several days. If you are still confused after that, I will try to back again to this project and reply to you.

@yyangzh
Copy link
Author

yyangzh commented Jul 10, 2020

Thanks for your reply, I will try my best to figure it out.

@jingedawang
Copy link

According to this paper, we should "reverse the roles of F1 and F2" instead of reversing the roles of I1 and I2. In this circumstance, this line should be

    d2 = one_iteration(F2, F1, h1, w1, h2, w2);

Please have a look at this problem.

@yyangzh
Copy link
Author

yyangzh commented Jul 10, 2020

According to this paper, we should "reverse the roles of F1 and F2" instead of reversing the roles of I1 and I2. In this circumstance, this line should be

    d2 = one_iteration(F2, F1, h1, w1, h2, w2);

Please have a look at this problem.

Yes. This way makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants