Migrate Android network stack to Go #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alalamav
commented
Apr 27, 2021
alalamav
commented
- Merges the Android client Go network stack from the go-tun2socks feature branch at ca0f04b.
- Deprecates shadowsocks-libev and badvpn-tun2socks for Android.
- Connectivity checks are also migrated to Go (VPN service process).
- Starting from v1.5.0, the Android clients has been released from the go-tun2socks branch.
- All code in this PR has been reviewed before merging into the go-tun2socks branch (i.e. Apple/Android: migrate connectivity checks to Go #664, Android: migrate to Shadowsocks Go #670).
- Updates the cordova-plugin-oultine documentation.
cordova-plugin-outline/README.md
Outdated
|
|
||
| ### Apple update instructions | ||
| ### Apple | ||
| This plugin targets Apple devices running iOS 11.0+ and macOS/OS X 10.11. |
cordova-plugin-outline/README.md
Outdated
|
|
||
| ### Android | ||
| This plugin targets Android devices running Lollipop (API 22), or higher. | ||
| outline-go-tun2socks is consumed by native platforms as a library. |
There was a problem hiding this comment.
This seems a little vague to me. Which platforms are native? And how do non-native platforms use it?
There was a problem hiding this comment.
I removed a reference to browser, which is not supported by the plugin.
Which platforms are native?
The ones supported: Android, iOS, macOS.
And how do non-native platforms use it?
They don't.
fortuna
approved these changes
Apr 28, 2021
cordova-plugin-outline/README.md
Outdated
| @@ -1,71 +1,31 @@ | |||
| # cordova-plugin-outline | |||
|
|
|||
| This Cordova plugin provides the ability to start a system-wide VPN, connected to a local Shadowsocks client. | |||
| Cordova plugin that implements a system-wide VPN to proxy device traffic over [Shadowsocks](https://shadowsocks.org/). | |||
There was a problem hiding this comment.
Suggested change
| Cordova plugin that implements a system-wide VPN to proxy device traffic over [Shadowsocks](https://shadowsocks.org/). | |
| Cordova plugin that implements a system-wide VPN to tunnel device traffic over [Shadowsocks](https://shadowsocks.org/). |
JonathanDCohen
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.