Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add-server-view communication:vpn-key iron-icon #1086

Merged
merged 4 commits into from Oct 15, 2021

Conversation

GrantASL19
Copy link
Contributor

This icon wasn’t loaded because of a missing app-root import.

When @polymer/iron-icons was upgraded to version 3 (as part of the
Polymer 3 upgrade) this one icon broke because it’s not part of the
default set.

Before:

Screen Shot 2021-10-08 at 10 34 20 AM

After:

Screen Shot 2021-10-08 at 10 34 26 AM

This icon wasn’t loaded because of a missing app-root import.

When @polymer/iron-icons was upgraded to version 3 (as part of the
Polymer 3 upgrade) this one icon broke because it’s not part of the
default set.
@google-cla google-cla bot added the cla: yes label Oct 8, 2021
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank youuu

@fortuna fortuna self-requested a review October 14, 2021 16:38
@fortuna fortuna merged commit 2e93ce2 into Jigsaw-Code:master Oct 15, 2021
@GrantASL19 GrantASL19 deleted the add-server-view-vpn-key-icon branch October 16, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants