Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sentry): clear name in device context #1207

Merged
merged 2 commits into from Mar 16, 2022
Merged

fix(sentry): clear name in device context #1207

merged 2 commits into from Mar 16, 2022

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Mar 14, 2022 •
edited

Is there anything else I need to do, here? We're not stripping out anything in the web error reporter - https://github.com/Jigsaw-Code/outline-client/blob/329df444be6ba91b212bb96727f6941ff6d750e3/src/www/app/error_reporter.ts

Also how do I test this - what are our sentry environments?

@daniellacosse daniellacosse temporarily deployed to Client iOS Debug March 14, 2022 20:01 Inactive
@daniellacosse daniellacosse marked this pull request as ready for review March 15, 2022 21:08
@daniellacosse daniellacosse temporarily deployed to Client iOS Debug March 15, 2022 21:11 Inactive
fortuna
fortuna approved these changes Mar 15, 2022
View reviewed changes
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a dev environment for Sentry. To test you can use that and submit a feedback report on Android, then check Sentry.

@cjhenck
Copy link
Contributor

cjhenck commented Mar 15, 2022

LGTM too

@cjhenck cjhenck assigned daniellacosse and unassigned cjhenck Mar 15, 2022
@daniellacosse daniellacosse merged commit be2b609 into master Mar 16, 2022
@daniellacosse daniellacosse deleted the daniellacosse/sentry_device_scrub branch March 6, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fortuna fortuna fortuna approved these changes

Assignees

@daniellacosse daniellacosse

Labels
!BLOCKING RELEASE! os/android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@daniellacosse @cjhenck @fortuna