Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use hidden directly on paper-item #1587

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

daniellacosse
Copy link
Contributor

No description provided.

@daniellacosse daniellacosse requested a review from a team as a code owner February 28, 2023 22:20
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks!

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (4514544) 45.89% compared to head (2faace8) 45.89%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1587   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files          40       40           
  Lines        1935     1935           
  Branches      308      308           
=======================================
  Hits          888      888           
  Misses       1047     1047           
Flag Coverage Δ
unittests 45.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/www/ui_components/app-root.js 4.83% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daniellacosse daniellacosse merged commit 91b4ce7 into master Feb 28, 2023
@daniellacosse daniellacosse deleted the daniellacosse/use_hidden_on_paper_item branch March 6, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants