chore: run npm clean across packages #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellacosse
changed the title
fortuna
approved these changes
Apr 18, 2024
| @@ -110,5 +110,8 @@ | |||
| "supports-color": "3.1.2", | |||
| "type-detect": "1.0.0" | |||
| }, | |||
| "license": "Apache" | |||
| "license": "Apache", | |||
There was a problem hiding this comment.
I think this is not the right designation. It may be Apache-2? Also, do we need it on every package.json?
There was a problem hiding this comment.
I don't think so, I can remove it in a license cleanup.
sbruens
added a commit
that referenced
this pull request
Apr 19, 2024
sbruens
added a commit
that referenced
this pull request
Apr 19, 2024
* chore(server_manager): fix the manager * Add `server_manager/node_modules` to cleanup. * Serve images for karma tests to avoid 1000+ 404 errors that make debugging hard. * Fix some more tests. * Dedupe `lit-html` that is messing up the `repeat` directive. * Update `package-lock.json`. * Revert `singleRun: true`. * Move lint check to its own workflow. * Fix `@typescript-eslint/eslint-plugin` dependency to handle TS decorators. * Correct dependency path. * Fix lit imports. * Make tests run in random order. * Remove cleaning of node_modules in favor of #1978.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.