Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cordova-android #853

Merged
merged 2 commits into from Sep 10, 2020
Merged

Update cordova-android #853

merged 2 commits into from Sep 10, 2020

Conversation

alalamav
Copy link
Contributor

  • Updates cordova-android to v9.0.0.
  • Increases the target SDK version to 29, and the minimum supported version to 22 (Android 5.1).

@alalamav alalamav self-assigned this Sep 10, 2020
bemasc
bemasc reviewed Sep 10, 2020
View reviewed changes
config.xml
<preference name="android-minSdkVersion" value="21" />
<preference name="android-targetSdkVersion" value="28" />
<preference name="android-minSdkVersion" value="22" />
<preference name="android-targetSdkVersion" value="29" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update README.md :)

Also, does this need an update to ANDROID_BUILD_TOOLS_VERSION in tools/build/Dockerfile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, updated README in 83a63a2.

I was able to build the app with the existing container image. I was thinking of updating it in a separate PR since it's a bigger change.

@alalamav alalamav merged commit 8542060 into alalama-cordova-updates Sep 10, 2020
@alalamav alalamav mentioned this pull request Sep 10, 2020
Merged
alalamav added a commit that referenced this pull request Sep 14, 2020
@alalamav
Update to Cordova 10 (#854)
77ffeb3 
- Update cordova-cli@10.0.0 (#846)
- Update cordova-ios@6.1.1 (#846)
- Update cordova-osx@6.0.0 (#852)
- Update cordova-android@9.0.0 (#853)
- Update android build docker image (#855)
@alalamav alalamav deleted the alalama-cordova-android-9 branch November 17, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bemasc bemasc bemasc approved these changes

Assignees

@alalamav alalamav

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alalamav @bemasc