Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cordova/apple/ios): update cordova-ios to v6.3.0 #1620

Merged
merged 5 commits into from
Apr 28, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Apr 24, 2023

This enables the inspection of web content post https://webkit.org/blog/13936/enabling-the-inspection-of-web-content-in-apps when debugging. It also allows us to bump Node up to version 18.

See https://cordova.apache.org/announcements/2023/04/15/cordova-ios-release-6.3.0.html for details on all fixes in v6.3.0..

@sbruens sbruens requested a review from a team as a code owner April 24, 2023 21:44
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks ok, but the build is broken

@daniellacosse
Copy link
Contributor

You'll need to change the CI to use node 18 as well

@sbruens
Copy link
Contributor Author

sbruens commented Apr 24, 2023

How do I get the workflow to use my changes to the workflow file? It's using the checked in version.

@jyyi1
Copy link
Contributor

jyyi1 commented Apr 25, 2023

How do I get the workflow to use my changes to the workflow file? It's using the checked in version.

No worries, it will automatically pick up the local change.

@sbruens sbruens changed the title chore(cordova/ios): Update cordova-ios to v6.3.0. chore(cordova/apple/ios): update cordova-ios to v6.3.0 Apr 28, 2023
@sbruens
Copy link
Contributor Author

sbruens commented Apr 28, 2023

Resolved the build issues. PTAL.

@sbruens sbruens merged commit 2cc6222 into master Apr 28, 2023
@sbruens sbruens deleted the sbruens/cordova-ios branch April 28, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants