Try Generics #19
Draft
Try Generics #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
commented
Aug 25, 2023
| // Connect establishes a connection with the endpoint, returning the connection. | ||
| Connect(ctx context.Context) (StreamConn, error) | ||
| } | ||
| type StreamEndpoint = Endpoint[StreamConn] |
There was a problem hiding this comment.
I wonder if this is better:
Suggested change
| type StreamEndpoint = Endpoint[StreamConn] | |
| type StreamEndpoint interface { | |
| Endpoint[StreamConn] | |
| } |
| @@ -21,10 +21,7 @@ import ( | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
I wonder if I should define
type PacketConn interface {
net.Conn
}That would be a parallel to StreamConn and allow us to expand in the future, if needed.
It would, however, be confusing with net.PacketConn. Perhaps it makes sense to call it DatagramConn or DgramConn, to mirror posix sockets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.