Correctly internationalize new UI access key placeholder name #574
Conversation
| @@ -97,7 +97,7 @@ | |||
| "gcp-firewall-create-3": "Type '0.0.0.0/0' in the 'Source IP ranges' field.", | |||
| "gcp-firewall-create-4": "Select 'Allow all' under 'Protocols and ports'.", | |||
| "gcp-firewall-create-5": "Click 'Create'.", | |||
| "key": "Key", | |||
| "key": "Key {keyId}", | |||
There was a problem hiding this comment.
@alalamav Do we need to update the messages in all languages before releasing?
There was a problem hiding this comment.
Yes, this will break non-English displayed names for unnamed keys to just say whatever the word is for "key"
There was a problem hiding this comment.
It would break translations. We have two options: wait for the new string to come out the tranlsation pipeline before importing it, or updating the string for all languages now.
There was a problem hiding this comment.
Addressed, see my below comment. This PR is now a no-op until we send the strings out for translation
This simply replicates the existing messages so we can release the Data Limits UI without waiting for these strings to be translated.
|
Added back the key ID to non-English languages to replicate what we're already doing so this won't block the Data Limits UI. |
* Correctly internationalize new UI access key placeholder name * Add back the keyID for non-English languages This simply replicates the existing messages so we can release the Data Limits UI without waiting for these strings to be translated. * Specify that keyId will be a number
* Correctly internationalize new UI access key placeholder name * Add back the keyID for non-English languages This simply replicates the existing messages so we can release the Data Limits UI without waiting for these strings to be translated. * Specify that keyId will be a number
No description provided.