New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests #693
Fix unit tests #693
Conversation
@@ -0,0 +1,11 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is having a separate tsconfig here going to keep us from sharing code between server_manager and shadowbox? I thought we were trying to work towards that end state
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so - sharing code between workspaces should be orthogonal to the build configuration of each package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: you can't share code that isn't shareable. If code depends on the broswer environment, you can't run on Node. If code depends on the Node environment, you can't run on the browser. There are polyfills for some things, but that's limited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the tests.
I think we can submit this, with some tweaks to the scripts that I mentioned.
However, we can still consider using webpack. It's possible to make it take all .spec.ts files as entrypoints, and output them separately. Then all you need to do is call jasmine on them. But that could be on another PR.
tsc
(nowebpack
).app.spec.ts
are still not running becauseapp.ts
dependencies (notably polymer) target the browser and use ES6 imports, which is not compatible with jasmine.