Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Dashboard with Sensor Cards #8

Merged
merged 7 commits into from
Apr 21, 2023

Conversation

qafui
Copy link
Contributor

@qafui qafui commented Mar 10, 2023

Initial implementation of a dashboard with sensor cards for the various data points. Styling is not included in this PR and will be added in a future issue.

@qafui qafui linked an issue Mar 10, 2023 that may be closed by this pull request
1 task
@naconnors
Copy link
Contributor

I have a prototype dashboard that I can demo on Thursday.

@jhodapp
Copy link
Member

jhodapp commented Mar 14, 2023

Awesome, can't wait to see it!

@jhodapp jhodapp added the feature work Specifically implementing a new feature label Apr 7, 2023
@jhodapp jhodapp marked this pull request as ready for review April 7, 2023 18:11
@jhodapp
Copy link
Member

jhodapp commented Apr 10, 2023

@naconnors @qafui Can either of you fill out a more detailed PR description for this work and set an appropriate milestone? I'm happy to review it more thoroughly afterwards.

@naconnors naconnors marked this pull request as draft April 11, 2023 04:15
@naconnors
Copy link
Contributor

I converted to draft for now because I spotted an issue when using ambi-rs as the backend instead of the ambi-mock-server. I will push changes to fix it and then move it back to ready for review.

@naconnors naconnors marked this pull request as ready for review April 14, 2023 01:36
Copy link
Member

@jhodapp jhodapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for this Nick/David. This is definitely something we can build upon. Also, thanks for setting up a basic test harness to also build on.

@qafui I think it makes sense for you to review this as well when you get a chance and recommend changes or approve if you're happy.

@naconnors naconnors merged commit 0ef00d6 into main Apr 21, 2023
1 check passed
@naconnors naconnors deleted the 3-implement-the-dashboard-page branch April 21, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature work Specifically implementing a new feature
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Implement the dashboard page
3 participants