Fix all router endpoint integration tests #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n't try and clone it
…n now works with the AuthSession and succeeds in its original purpose again
Closed
jhodapp
commented
Feb 26, 2024
|
|
||
| /// Creates a test user::Model entity instance that can be used by tests to | ||
| /// log in to the /login endpoint and create a valid AuthSession. | ||
| pub fn get_user() -> anyhow::Result<user::Model> { |
There was a problem hiding this comment.
@calebbourg what do you think of this function name get_user()? Do you think it's confusing such that you'd expect some more dynamic getter of a property instead of generating a static instance of a user::Model?
Would create_user() or create_test_user() be better or do you think it's fine as is and I'm just overthinking it?
calebbourg
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes all of the broken tests in router.rs that broke when we introduced AuthSession from axum-login and the Organization endpoints being protected behind a valid login session.
GitHub Issue: Fixes #32
Changes
DatabaseConnectioninstance is shared betweenAppStateanduser::Backend(see this Rust documentation for how Arc allows this sharing viaclone())Testing Strategy
cargo testand ensure all tests passConcerns
None