Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix observatory metrics #1

Closed
fortytw2 opened this issue Jan 4, 2017 · 4 comments
Closed

prefix observatory metrics #1

fortytw2 opened this issue Jan 4, 2017 · 4 comments

Comments

@fortytw2
Copy link

fortytw2 commented Jan 4, 2017

would be wonderful if the exported metrics were something like observatory_* per https://prometheus.io/docs/practices/naming/ - helps a lot when you have a large number of metrics

@smon
Copy link
Contributor

smon commented Jan 4, 2017

Hey @fortytw2, thanks for reporting!

The namespace 'observatory' gets passed to the prometheus.Desc which gets used when calling MustNewConstMetric.
See: https://github.com/Jimdo/observatory-exporter/blob/master/exporter.go#L24
https://github.com/Jimdo/observatory-exporter/blob/master/exporter.go#L56

That should do already what you're asking for. I am able to query our prometheus server that way and see the observatory_ 'prefix'..

@fortytw2
Copy link
Author

fortytw2 commented Jan 4, 2017

fantastic, @shartmnn - I was a bit confused in the readme, here https://github.com/Jimdo/observatory-exporter#exposed-metrics (haven't given it a spin yet, either :s)

@smon
Copy link
Contributor

smon commented Jan 4, 2017

I updated the readme. The metrics names now include the namespace/prefix. 631d7ca

Good catch!

@fortytw2
Copy link
Author

fortytw2 commented Jan 4, 2017

sweet! 😄

@fortytw2 fortytw2 closed this as completed Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants