Skip to content
This repository has been archived by the owner on Jun 4, 2019. It is now read-only.

Use the built-in getProvider() and region. #12

Merged
merged 1 commit into from
Jun 9, 2017
Merged

Use the built-in getProvider() and region. #12

merged 1 commit into from
Jun 9, 2017

Conversation

sammarks
Copy link
Contributor

@sammarks sammarks commented Jun 7, 2017

Resolves #11.

@sbstjn sbstjn requested a review from HenrikFricke June 9, 2017 10:05
@sbstjn sbstjn requested a review from alexzelenuyk June 9, 2017 10:06
HenrikFricke
HenrikFricke approved these changes Jun 9, 2017
View reviewed changes
Copy link
Contributor

@HenrikFricke HenrikFricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good points, thanks for the improvements 👍

@sbstjn sbstjn merged commit 396be37 into Jimdo:master Jun 9, 2017
@sbstjn
Copy link
Contributor

sbstjn commented Jun 9, 2017

Included in the v0.1.0 release and published to NPM 🎉

@sammarks sammarks deleted the built-in-provider-region branch June 9, 2017 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HenrikFricke HenrikFricke HenrikFricke approved these changes

@alexzelenuyk alexzelenuyk Awaiting requested review from alexzelenuyk

Assignees

@alexzelenuyk alexzelenuyk

@HenrikFricke HenrikFricke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sammarks @sbstjn @HenrikFricke @alexzelenuyk