Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding rest of missing set functions #25

Merged
merged 13 commits into from
May 18, 2018
Merged

Adding rest of missing set functions #25

merged 13 commits into from
May 18, 2018

Conversation

danben4
Copy link
Contributor

@danben4 danben4 commented May 6, 2018 •
edited
Loading

Added rest of missing set functions along with tests.
They are the following:

  1. mutableSetMillisecond
  2. setMillisecond
  3. mutableSetSecond
  4. setSecond
  5. mutableSetMinute
  6. setMinute
  7. mutableSetDay
  8. setDay
  9. mutableSetWeekday
  10. setWeekday
  11. mutableSetIsoWeekday
  12. setIsoWeekday
  13. mutableSetWeek
  14. setWeek
  15. mutableSetIsoWeek
  16. setIsoWeek
  17. mutableSetQuarter
  18. setQuarter
  19. mutableSetWeekYear
  20. setWeekYear
  21. mutableSetIsoWeekYear
  22. setIsoWeekYear

@chenglou @jimexist

@danben4
Copy link
Contributor Author

danben4 commented May 17, 2018

@jimexist Could we merge this PR anytime soon? 😈

@jimexist jimexist merged commit 2c8a366 into jimexist:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimexist jimexist jimexist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danben4 @jimexist